Re: [PATCH] input: Update Elantech touchpad driver to v5 forkernel 2.6.27-rc5-mm1

[Arjan Opmeer]

Hi Dmitry,

(Sorry for calling you Dimitry earlier :)

On Fri, Sep 19, 2008 at 12:17:27AM -0400, Dmitry Torokhov wrote:
> On Sun, Sep 14, 2008 at 05:23:44AM +0200, Arjan Opmeer wrote:
> > 
> > Update the Elantech touchpad driver to v5
> 
> Could you tell me if issues with pressure reporting mentioned in bugzilla
> #8781 have been resolved?

I am not exactly sure what the issue is that is described there.

As far as I know the touchpad does not report pressure (maybe the EeePC
style touchpad does, but I do not have hands on experience with that).
However the Xorg Synaptics driver requires pressure events to work. So I
chose a default pressure value and the driver always toggles between no
pressure and default pressure for no touch and touch respectively. This
seems to work well for all my testers as I have not heard any complaints.

A related issue seems to be that the Ubuntu packaged version of the Xorg
Synaptics driver appears to have a bug where adjusting MaxTapTime doesn't
have any effect. In the absence of true pressure reporting this is the
primary parameter to configure ones personal tapping preference for the
Elantech touchpad. I believe the bug reporter in question wants to set this
value to 0 to disable tapping altogether (although the TouchpadOff option
would be better suited), but because of this bug cannot do so.

So all in all I am not quite sure that this is a problem with the Elantech
driver per se.

> I am about to put the driver in my tree and need to know if I can enable
> it unconditionally or need to mark it experimental.

Well, either is fine with me. Just getting it in the mainline kernel will
give it a broader exposure and more testing I guess.


Arjan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/