Re: [PATCH] dmatest: properly handle duplicate DMA channels

From: Haavard Skinnemoen
Date: Thu Sep 18 2008 - 11:53:42 EST


Timur Tabi <timur@xxxxxxxxxxxxx> wrote:
> Haavard Skinnemoen wrote:
>
> > ...though I don't really see why you have to use
> > list_for_entry_safe()...
>
> You use it in dmatest_remove_channel(), so I figured I'd do the same thing.

dmatest_remove_channel() may call list_del() on the current entry, so it
has to. As long as you're not altering the list, the _safe() variant
shouldn't be necessary.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/