Re: [PATCH -mm] eeepc: depends on RFKILL

From: Corentin Chary
Date: Tue Sep 16 2008 - 03:06:15 EST


Yep, it should depends on RFKILL, and I should start porting
asus-laptop to rfkill.
Thanks for this patch.

On Mon, Sep 15, 2008 at 9:52 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL.
> Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.
>
> eeepc-laptop.c:(.text+0xd5a7b): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5b04): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5b48): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5bd4): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5ece): undefined reference to `rfkill_unregister'
> eeepc-laptop.c:(.text+0xd5ef6): undefined reference to `rfkill_unregister'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> cc: Corentin Chary <corentincj@xxxxxxxxxx>
> ---
> drivers/misc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.27-rc5-mm1.orig/drivers/misc/Kconfig
> +++ linux-2.6.27-rc5-mm1/drivers/misc/Kconfig
> @@ -410,6 +410,7 @@ config EEEPC_LAPTOP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on HWMON
> depends on EXPERIMENTAL
> + depends on RFKILL
> ---help---
> This driver supports the Fn-Fx keys on Eee PC laptops.
> It also adds the ability to switch camera/wlan on/off.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/