Re: [PATCH] gpio_free might sleep, blackfin architecture

[Bryan Wu]

On Tue, Sep 16, 2008 at 4:02 AM, Uwe Kleine-König
<ukleinek@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> According to the documentation gpio_free should only be called from task
> context only.  To make this more explicit add a might sleep to all
> implementations.
>
> This patch changes the gpio_free implementations for the blackfin
> architecture.
>

It looks fine for me, thanks a lot.

Acked-by: Bryan Wu <cooloney@xxxxxxxxxx>


> Signed-off-by: Uwe Kleine-König <ukleinek@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: David Brownell <david-b@xxxxxxxxxxx>
> Cc: Bryan Wu <cooloney@xxxxxxxxxx
> Cc: uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Kay Sievers <kay.sievers@xxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
> ---
>  arch/blackfin/kernel/bfin_gpio.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c
> index ecbd141..394006d 100644
> --- a/arch/blackfin/kernel/bfin_gpio.c
> +++ b/arch/blackfin/kernel/bfin_gpio.c
> @@ -1151,6 +1151,8 @@ void gpio_free(unsigned gpio)
>        if (check_gpio(gpio) < 0)
>                return;
>
> +       might_sleep();
> +
>        local_irq_save(flags);
>
>        if (unlikely(!(reserved_gpio_map[gpio_bank(gpio)] & gpio_bit(gpio)))) {
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/