Re: [PATCH 00/10] ide-cd: use generic ide_issue_pc

[Bartlomiej Zolnierkiewicz]

Hi,

On Sunday 14 September 2008 13:35:48 Borislav Petkov wrote:
> Hi Bart,
> 
> here are some patches converting ide-cd to using ide_issue_pc. Next is
> replacing cdrom_transfer_packet_command with ide_transfer_pc.
> 
>  drivers/ide/ide-atapi.c  |   71 ++++++++++++++++++++++---------
>  drivers/ide/ide-cd.c     |  104 ++++++---------------------------------------
>  drivers/ide/ide-cd.h     |   30 +++++++++++++-
>  drivers/ide/ide-floppy.c |    2 +-
>  drivers/ide/ide-tape.c   |    2 +-
>  drivers/scsi/ide-scsi.c  |    3 +-
>  include/linux/ide.h      |    5 ++-
>  7 files changed, 102 insertions(+), 115 deletions(-)

Thanks for finding time to work on this.  Overall it looks good
and I applied some patches already (#1/2/4) but the rest would
need some final recasting/polishing before they can go in (please
see the individual replies for details).

Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/