Re: [PATCH] ibmasr: remove unnecessary spin_unlock()

[Andrey Panin]

On 257, 09 13, 2008 at 06:47:19 +0900, Akinobu Mita wrote:
> __asr_toggle() is always called with asr_lock held.
> But there is unnecessary spin_unlock() call in __asr_toggle().
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: Andrey Panin <pazke@xxxxxxxxx>

Acked-by: Andrey Panin <pazke@xxxxxxxxx>

> ---
>  drivers/watchdog/ibmasr.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: 2.6-git/drivers/watchdog/ibmasr.c
> ===================================================================
> --- 2.6-git.orig/drivers/watchdog/ibmasr.c
> +++ 2.6-git/drivers/watchdog/ibmasr.c
> @@ -85,7 +85,6 @@ static void __asr_toggle(void)
>  
>  	outb(reg & ~asr_toggle_mask, asr_write_addr);
>  	reg = inb(asr_read_addr);
> -	spin_unlock(&asr_lock);
>  }
>  
>  static void asr_toggle(void)
> 

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@xxxxxxxxx		| PGP key: wwwkeys.pgp.net

Attachment: signature.asc
Description: Digital signature