Re: [RFC][PATCH] x86: add memory clobber in switch_to()

[Ingo Molnar]

* Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

> There are more places which have segment register reloads without 
> adding memory clobbers. Should we fix them up? Here's one of them:

yes, i think so.

> >From 5f135687f7730fbdd979b6fb408fd3ca08a0a678 Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@xxxxxxxxx>
> Date: Sun, 14 Sep 2008 18:53:22 +0200
> Subject: [PATCH] x86: add memory clobber in switch_to()
> 
> Segment registers are reloaded, so we should add a memory clobber. The 
> generated assembly code is identical in my tests, but this doesn't 
> mean it is necessarily true for all configurations/compilers.

applied to tip/x86/core, thanks Vegard.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/