Re: [PATCH] Fix section for snd-aica platform driver

[Takashi Iwai]

At Sun, 14 Sep 2008 21:32:33 +0200,
Uwe Kleine-König wrote:
> 
> Don't use __init but __devinit to define probe function.  A pointer to
> snd_aica_probe is passed to the core via platform_driver_register and so the
> function must not disappear after the module is loaded.  Using __init
> and having HOTPLUG=y and SND_AICA=m the following probably oopses:
> 
> 	echo -n AICA > /sys/bus/platform/driver/AICA/unbind
> 	echo -n AICA > /sys/bus/platform/driver/AICA/bind
> 
> Strange enough add_aicamixer_controls which is only called by
> snd_aica_probe was already using __devinit.
> 
> While at it move the remove function to .devexit.text section.
> 
> Signed-off-by: Uwe Kleine-König <ukleinek@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Adrian McMenamin <adrian@xxxxxxxxxxxxxxxxx>
> Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
> ---
>  sound/sh/aica.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks, applied now.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/