[PATCH] timers: fix itimer/many thread hang, fix #2

From: Ingo Molnar
Date: Sun Sep 14 2008 - 11:03:52 EST


fix the UP build:

In file included from arch/x86/kernel/asm-offsets_32.c:9,
from arch/x86/kernel/asm-offsets.c:3:
include/linux/sched.h: In function âthread_group_cputime_clone_threadâ:
include/linux/sched.h:2272: warning: no return statement in function returning non-void
include/linux/sched.h: In function âthread_group_cputime_account_userâ:
include/linux/sched.h:2284: error: invalid type argument of â->â (have âstruct task_cputimeâ)
include/linux/sched.h:2284: error: invalid type argument of â->â (have âstruct task_cputimeâ)
include/linux/sched.h: In function âthread_group_cputime_account_systemâ:
include/linux/sched.h:2291: error: invalid type argument of â->â (have âstruct task_cputimeâ)
include/linux/sched.h:2291: error: invalid type argument of â->â (have âstruct task_cputimeâ)
include/linux/sched.h: In function âthread_group_cputime_account_exec_runtimeâ:
include/linux/sched.h:2298: error: invalid type argument of â->â (have âstruct task_cputimeâ)
distcc[14501] ERROR: compile arch/x86/kernel/asm-offsets.c on a/30 failed
make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
include/linux/sched.h | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 26d7a5f..ed355f0 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2251,6 +2251,7 @@ static inline void thread_group_cputime_free(struct signal_struct *sig)
static inline int thread_group_cputime_clone_thread(struct task_struct *curr,
struct task_struct *tsk)
{
+ return 0;
}

static inline void thread_group_cputime(struct task_struct *tsk,
@@ -2263,21 +2264,21 @@ static inline void thread_group_cputime_account_user(
struct thread_group_cputime *tgtimes,
cputime_t cputime)
{
- tgtimes->totals->utime = cputime_add(tgtimes->totals->utime, cputime);
+ tgtimes->totals.utime = cputime_add(tgtimes->totals.utime, cputime);
}

static inline void thread_group_cputime_account_system(
struct thread_group_cputime *tgtimes,
cputime_t cputime)
{
- tgtimes->totals->stime = cputime_add(tgtimes->totals->stime, cputime);
+ tgtimes->totals.stime = cputime_add(tgtimes->totals.stime, cputime);
}

static inline void thread_group_cputime_account_exec_runtime(
struct thread_group_cputime *tgtimes,
unsigned long long ns)
{
- tgtimes->totals->sum_exec_runtime += ns;
+ tgtimes->totals.sum_exec_runtime += ns;
}

#endif /* CONFIG_SMP */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/