Re: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driverimprovements

[Atsushi Nemoto]

On Sat, 13 Sep 2008 10:19:06 -0500, David Fries <david@xxxxxxxxx> wrote:
> > For now rbtx49xx ne platform devices use -1 for pdev->id, but it may
> > change.  Please don't assume it.
> 
> Does this work?
> -	if (0 <= this_dev && this_dev < MAX_NE_CARDS) {
> +	if (!res) {

It should work (not tested: I have no access to the board few days),
but if someone defined ne platform device with pdev->id == -1 and he
forgot to declare IO resources, but things happen.  Checking this_dev
range before accessing io[] array would be better.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/