Re: [PATCH 1/2] [PATCH] ne.c fix rmmod, platform driverimprovements

[Atsushi Nemoto]

On Sat, 13 Sep 2008 09:44:57 -0500, David Fries <david@xxxxxxxxx> wrote:
> I reformatted your patch and added a comment.  Does this work for you?
> 
> diff --git a/drivers/net/ne.c b/drivers/net/ne.c
...
>  	/* Update with any values found by probing. */
> -	io[this_dev] = dev->base_addr;
> -	irq[this_dev] = dev->irq;
> +	if (0 <= this_dev && this_dev < MAX_NE_CARDS) {
> +		io[this_dev] = dev->base_addr;
> +		irq[this_dev] = dev->irq;
> +	}
>  	return 0;
>  }

For now rbtx49xx ne platform devices use -1 for pdev->id, but it may
change.  Please don't assume it.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/