Re: [PATCH] apci: dump slit

From: Andi Kleen
Date: Fri Sep 12 2008 - 18:25:40 EST


On Fri, Sep 12, 2008 at 02:54:12PM -0700, Yinghai Lu wrote:
> On Fri, Sep 12, 2008 at 2:30 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> >
> > Yes excellent point. Should we dump the complete ACPI tables?
> > Do you prefer hexdump
>
> good point. there is one time BIOS put blank slit there. (only have
> acpi table header)
> only after dump that earlier in kernel boot log, they shut up and go
> back to fix their problem.

You should have asked them to run firmwaretestkit (and if fwtestkit
doesn't test for a correct SLIT fix it there). That is what
it is for. But adding it
to all Linux bootlogs ever just for this special case is the wrong way.


-Andi

--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/