Re: [RFC v4][PATCH 4/9] Memory management (dump)

From: Dave Hansen
Date: Fri Sep 12 2008 - 12:57:23 EST


On Tue, 2008-09-09 at 03:42 -0400, Oren Laadan wrote:
> + if (unlikely(ret < 0)) {
> + nr = pgarr->nr_free - nr;
> + while (nr--)
> + page_cache_release(*(--pagep));
> + return ret;
> + }

Oren, please take a good, hard look through all these patches (i.e.
grep) and find all of the (un)likely calls and toss them out. They're
unneeded.
>
-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/