Re: tpm-correct-tpm-timeouts-to-jiffies-conversion.patch -> 2.6.27

From: Valdis . Kletnieks
Date: Fri Sep 12 2008 - 11:25:44 EST


On Thu, 11 Sep 2008 12:03:52 +0200, Marcin Obara said:

> > Why? I wasn't aware that this fixed anything which anyone had observed
> > (pokes tongue out at the changelog).
> >
>
> This fixes i.e.: long hang while loading TPM driver, if TPM chip
> starts in "Idle" state instead of "Ready" state.
> Without this patch - 'modprobe' may hang for 30 seconds or more.
> Please, push this patch into 2.6.27.

I personally don't care whether this goes into .27 or waits till .28. However,
I *would* appreciate it if we make sure that whenever it goes go upstream, we
also send tpm-work-around-bug-in-broadcom-bcm0102-chipset.patch at the same
time.

I have to admit that it's not exactly confidence inspiring - if the Broadcom
chip gets timeout units wrong, what *other* issues lurk in its silicon? It's
bad enough when you find bugs in a RAID chipset or mouse hardware - it's even
worse when it's a security chip.. ;)


Attachment: pgp00000.pgp
Description: PGP signature