Re: [update3] [PATCH] init: bzip2 or lzma -compressed kernels andinitrds

From: H. Peter Anvin
Date: Thu Sep 11 2008 - 19:22:45 EST

Alain Knaff wrote:
There is no reason to include header files conditionally.

It might be worthwhile to create a proper subdirectory rather than using
an underscored namespace (also, in general, dashes are preferred in

I hate to contradict you, but in that case, lots of other filenames
would need fixing too:

Not arguing that. However, in this case I think the right thing is to make a subdirectory.

Any reason to not just use <linux/compiler.h> here?

As you may have understood, the decompressors themselves are samples
and/or reference implementations downloaded from elsewhere, and thus
might not be up to the coding standards of the rest of the kernel.

I'm familiar with that. However, I think in this case it is preferrable to use the all-kernel facilities, since there is an obvious direct mapping.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at