Re: [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFiCODEC and PMU

From: Mark Brown
Date: Thu Sep 11 2008 - 06:03:55 EST


On Wed, Sep 10, 2008 at 08:38:04PM +0100, Liam Girdwood wrote:
> On Wed, 2008-09-10 at 20:13 +0100, Mark Brown wrote:

> > Yeah, I considered doing that but decided that it was more trouble than
> > it was worth - the device has far fewer functions than the WM8350.

> Wouldn't splitting out audio from power at least half the size of the
> header. Imho probably making it easier to track down definitions per
> function.

It's a bit more than half the file for the audio stuff. To be honest I
never found much problem - I tend to just search within the file to find
what I need. I'll split out most of the audio definitions into a
separate header, though not quite all since some of the audio registers
are shared with other functionality.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/