Re: [PATCH 3/3] OLPC: touchpad driver (take 2)

From: Andres Salomon
Date: Thu Sep 11 2008 - 01:29:32 EST


On Wed, 10 Sep 2008 17:55:13 -0400
Andres Salomon <dilinger@xxxxxxxxxx> wrote:
[...]
>
>
> What do you think about either changing PSMOUSE_DEFINE_ATTR
> to take an additional 'raw' argument (meaning psmouse->state is
> not checked, and psmouse_deactivate/psmouse_activate are not
> called), or alternatively adding new helper functions that just
> handle the locking (__PSMOUSE_DEFINE_ATTR() and
> __psmouse_attr_{set,show}_helper())? I'd prefer the raw
> argument.

Ie, something like this (I'll resend all patches later if you approve).