Re: [PATCH] memstick: fix MSProHG 8-bit interface mode support

[Alex Dubov]

--- On Wed, 9/10/08, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] memstick: fix MSProHG 8-bit interface mode support
> To: oakad@xxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx, oakad@xxxxxxxxx
> Date: Wednesday, September 10, 2008, 5:41 PM
> On Thu, 11 Sep 2008 01:09:55 +1000
> oakad@xxxxxxxxxxxxxx wrote:
> 
> > * Fix support of 8-bit interface mode
> 
> what was wrong with it?

It never worked properly. The only adapter I have which supports the
8b mode (the Jmicron) had some problems with its clock wiring and they
discovered it only now. We also discovered that ProHG media is more
sensitive to the ordering of initialization commands.

> 
> > * Make driver to fallback to highest supported mode
> instead of always
> >   falling back to serial
> 
> why?

The driver will attempt the switch to 8b mode for any new MSPro card,
but not all of them support it. Previously, these new cards ended up
in serial mode, which is not the best idea (they work fine with 4b,
after all).




      
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/