Re: [2.6 patch] fix pciehp_free_irq()

From: Jesse Barnes
Date: Wed Sep 10 2008 - 13:51:24 EST


On Tuesday, September 9, 2008 3:52 pm Kenji Kaneshige wrote:
> ----- Original Message -----
>
> >From: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> >To: Adrian Bunk <bunk@xxxxxxxxxx>
> >Subject: Re: [2.6 patch] fix pciehp_free_irq()
> >Date: Tue, 9 Sep 2008 11:40:41 -0700
> >Cc: Kenji Kaneshige <kaneshige.kenji@xxxxxxxxxxxxxx>,
> > linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx
> >
> >On Wednesday, August 27, 2008 3:05 pm Adrian Bunk wrote:
> >> This patch fixes an obvious bug (loop was never entered) caused by
> >> commit 820943b6fc4781621dee52ba026106758a727dd3
> >> (pciehp: cleanup pcie_poll_cmd).
> >>
> >> Reported-by: Adrian Bunk <bunk@xxxxxxxxxx>
> >> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>
> >
> >Applied to my linux-next branch. Kenji-san do you think this should go
> > into 2.6.27? I haven't heard any regression reports about it, but it
> > does seem like a good and simple fix...
>
> Though regression was not reported, it is actually a regression internally.
> It doesn't have a big impact against the hotplug controller that supports
> "command completed interrupt", but it might have a impact against the
> controller that doesn't support "command completed interrupt". So I think
> it should go into 2.6.27. As you said, the patch looks good and simple.

Ok, thanks, I've queued it up for 2.6.27.

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/