Re: [PATCH 01/18] lirc core device driver infrastructure

[Christoph Hellwig]

On Wed, Sep 10, 2008 at 02:24:36PM +0200, Janne Grunau wrote:
> On Tuesday 09 September 2008 15:01:02 Christoph Hellwig wrote:
> 
> > > +	do {
> > > +		if (ir->open) {
> > > +			if (ir->jiffies_to_wait) {
> > > +				set_current_state(TASK_INTERRUPTIBLE);
> > > +				schedule_timeout(ir->jiffies_to_wait);
> > > +			} else {
> > > +				interruptible_sleep_on(
> > > +					ir->p.get_queue(ir->p.data));
> > > +			}
> >
> > No sleep on, please.  But this one should be trivial to fix anyway,
> > by just changing this to a
> >
> > 	set_current_state(TASK_INTERRUPTIBLE);
> > 	schedule();
> >
> > and using wake_up_process in the wakeup path.
> 
> No driver uses the get_queue callback. So I'm inclined to just remove 
> it. Christoph, any objections?

Sounds good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/