Re: forcedeth: option to disable 100Hz timer (try 2)

From: Bodo Eggert
Date: Wed Sep 10 2008 - 07:08:18 EST


Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx> wrote:

> On some hardware no TX done interrupts are generated, thus special
> 100Hz timer interrupt is required to handle this situation properly.
> Other device do not require that timer interrupt feature.
>
> Forcedeth has a DEV_NEED_TIMERIRQ flag to mark the broken devices.
> Unfortunately, nobody know the actual list of broken devices, so all
> device has this flag on. Other problem, this flag is not user visible,
> so the kernel recompilation is required to disable timer interrupts and
> test a device.

Why don't you disable the interrupt after the first TX_done interrupt
(no RX pending, no RX done)? Maybe you can printk "forcedeth device [x,y] does
not need timer interrupts, please send this line to you@xxxxxxxxxxx", too.
Maybe you can even disable it if no TX is to be done.

OTOH, this fix is available, it's possibly the best to use it for now.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/