Re: [PATCH] drivers/ide/ide-probe.c: uninitialized variable 'rc'

From: Ingo Molnar
Date: Wed Sep 10 2008 - 02:55:38 EST

* Steven Noonan <steven@xxxxxxxxxxxxxx> wrote:

> Fixed the warning by initializing 'rc' to zero.
> Signed-off-by: Steven Noonan <steven@xxxxxxxxxxxxxx>
> ---
> drivers/ide/ide-probe.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

i've Cc:-ed Bartlomiej, who maintains drivers/ide/ide-probe.c. Your
fix/cleanup looks fine to me.

About the "whom to Cc:" question. Sadly, the MAINTAINERS file is
non-obvious to parse to newbies: there's no clear mapping from file to
maintainer. (it's rather useless even to oldbies.)

The method i use to determine whom to Cc: if i change something in a
file is this ~/bin/git-authors script:

git log $@ | grep Author: | cut -d: -f2 | sort | uniq -c | sort -n | tail -5

(also attached)

for drivers/ide/ide-probe.c, it gives:

earth4:~/tip> git-authors-email drivers/ide/ide-probe.c
2 Christoph Lameter <christoph@xxxxxxxxxxx>
2 Greg Kroah-Hartman <gregkh@xxxxxxx>
3 Jens Axboe <jens.axboe@xxxxxxxxxx>
4 Jens Axboe <axboe@xxxxxxx>
135 Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

if there output of git-authors-email is too flat and you are unsure
about whom to Cc:, take a look at git-log drivers/ide/ide-probe.c output
and chose the people who do material changes to a file (not drive-by


#[ $# -lt "1" ] && { echo 'usage: git authors <files...>'; exit -1; }

git log $@ | grep Author: | cut -d: -f2 | sort | uniq -c | sort -n | tail -5