Re: [PATCH] Cleanup to make remove_memory() arch neutral

[Badari Pulavarty]

On Tue, 2008-09-09 at 10:21 +0900, Yasunori Goto wrote:
> > On Mon, 08 Sep 2008 14:52:34 -0700
> > Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
> > 
> > > There is nothing architecture specific about remove_memory().
> > > remove_memory() function is common for all architectures which
> > > support hotplug memory remove. Instead of duplicating it in every
> > > architecture, collapse them into arch neutral function.
> > > 
> > > Signed-off-by: Badari Pulavarty <pbadari@xxxxxxxxxx>
> > > 
> > >  arch/ia64/mm/init.c   |   17 -----------------
> > >  arch/powerpc/mm/mem.c |   17 -----------------
> > >  arch/s390/mm/init.c   |   11 -----------
> > >  mm/memory_hotplug.c   |   10 ++++++++++
> > >  4 files changed, 10 insertions(+), 45 deletions(-)
> > 
> > I spent some time trying to build-test this on ia64 and gave up.  How
> > the heck do you turn on memory hotplug on ia64?
> > 
> 
> EXPORT_SYMBOL_GPL(remove_memory) is removed.
> It is required by drivers/acpi/acpi_memhotplug.ko.

Thanks for catching it. I forgot that it was being used
by acpi. Since we didn't export it for ppc and s390,
I assumed its safe to remove the export. Sorry !!

Thanks,
Badari

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/