Re: [PATCH 1/1] drivers/usb/host/pci-quirks.c: wait for EHCI handofffar too long in quirk_usb_disable_ehci()

From: Alan Stern
Date: Tue Sep 09 2008 - 10:13:50 EST


On Mon, 8 Sep 2008, Andrew Morton wrote:

> On Sat, 6 Sep 2008 17:29:53 -0700 Steven Noonan <steven.noonan@xxxxxxxxxxxxxx> wrote:
>
> > This patch fixes a very noticeable bootup delay on some
> > systems (in my particular case, an HP dv5178us). The
> > problem is caused by a buggy BIOS which doesn't properly
> > announce that the handoff was completed.
> >
> > The delay in the current version of pci-quirks.c is 5 seconds,
> > which I've cut down to 0.5 seconds.

> I guess it risks breaking someone else's system. Or perhaps the number
> was just grabbed out of the air.

As far as I know, it was indeed just grabbed out of the air. The spec
specifically avoids giving an upper limit on how long to wait.

> Can we do a separate quirk just for that machine (and ones with the
> same bug)?

My BIOS has the same bug. I wouldn't mind seeing the delay reduced.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/