Re: [PATCH 01/18] lirc core device driver infrastructure

[Sebastian Siewior]

* Janne Grunau | 2008-09-09 11:53:48 [+0200]:

>> >+
>> >+	bytes_in_key = p->code_length/8 + (p->code_length%8 ? 1 : 0);
>>
>> did you actually pass checkpatch.pl ?
>
>yes, and while this is ugly I see no obvious CodingStyle violation.
>
>is following better?
>
>bytes_in_key = p->code_length/8;
>if (p->code_length%8)
>	bytes_in_key++;
>
bytes_in_key = p->code_length / 8;
if (p->code_length % 8)
	bytes_in_key++;

I meant the missing spaces around / and %. Looking now at it, it seems
that it behaves like DIV_ROUND_UP(). The magic of spaces :)

>
>Janne

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/