Re: [PATCH 0/18] linux infrared remote control drivers

[Janne Grunau]

On Tuesday 09 September 2008 09:06:03 Alexey Dobriyan wrote:
>
> All version.h and autoconf.h inclusions aren't needed.

I'll remove them.

> #ifdef MODULE is gross and very old. Don't need that. Just use
>
> 	static int __init x_init(void)
> 	{
> 		...
> 	}
>
> 	static void __exit x_exit(void)
> 	{
> 		...
> 	}
> 	module_init(x_init);
> 	module_exit(x_exit);
> 	MODULE_LICENSE
> 		...
>
> It will work correctly in modular and built-in case.

Will do so.

> Static number of devices is simple but how about adding them
> dynamically.

Will have a look

Janne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/