Re: [RFC][PATCH] MMC: Use write timeout value as read from CSR

From: Pierre Ossman
Date: Tue Sep 09 2008 - 03:22:28 EST

On Mon, 8 Sep 2008 14:28:00 +0100
"Matt Fleming" <mattjfleming@xxxxxxxxxxxxxx> wrote:

> 2008/9/7 Pierre Ossman <drzeus-mmc@xxxxxxxxx>:
> >
> > This actually isn't fully correct for SD either as it only specifies
> > that 250 ms is the upper bound on the timeout.
> >
> > I believe the proper way of solving this is to have mmc_spi respect the
> > timeouts set in the request structure. Modify mmc_set_data_timeout() if
> > necessary.
> >
> You're right, I changed the patch accordingly (I also fixed the read
> timeout path).

This still doesn't use the fields from the request structure. E.g. SDIO
support is probably still broken here as it mandates a timeout of 1
second for data transfers.

-- Pierre Ossman

Linux kernel, MMC maintainer
rdesktop, core developer

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at