Re: [PATCH] exclude h8300 local symbols (Re: kallsyms exclude local symbols)

[Yoshinori Sato]

At Sun, 7 Sep 2008 23:56:27 -0700,
Andrew Morton wrote:
> 
> On Thu, 07 Aug 2008 19:36:18 -0400 Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > At Thu, 07 Aug 2008 13:00:05 +0100,
> > Paulo Marques wrote:
> > > 
> > > Yoshinori Sato wrote:
> > > > h8300's nm output include '.Lfoo' local symbols.
> > > > [...]
> > > >  	/* exclude also MIPS ELF local symbols ($L123 instead of .L123) */
> > > > -	else if (str[0] == '$')
> > > > +	else if (str[0] == '$' || str[0] == '.')
> > > 
> > > The comment above needs some updating too. Something along these lines:
> > > 
> > > /* exclude also MIPS ELF local symbols (eg. $L123) and h8300 (eg .LM10) */
> > > 
> > > Other than that, the patch seems fine.
> > > 
> > > -- 
> > > Paulo Marques - www.grupopie.com
> > > 
> > > "...so she told me it was either her or the ham radio, over."
> > 
> > Thanks reply.
> > 
> > Update comment.
> > And same problem in modpost.
> > 
> > Warning message dirty.
> > WARNING: vmlinux.o(.text+0x304b): Section mismatch in reference from the variable .LM10 to the variable .init.text:_free_area_init
> > The function .LM10() references
> > the variable __init _free_area_init.
> > This is often because .LM10 lacks a __init
> > annotation or the annotation of _free_area_init is wrong.
> > 
> > fix it.
> > WARNING: vmlinux.o(.text+0x304b): Section mismatch in reference from the variable _paging_init to the variable .init.text:___alloc_bootmem
> > The function _paging_init() references
> > the variable __init ___alloc_bootmem.
> > This is often because _paging_init lacks a __init
> > annotation or the annotation of ___alloc_bootmem is wrong.
> > 
> > Signed-off-by: Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
> > 
> > ---
> >  scripts/kallsyms.c    |    5 +++--
> >  scripts/mod/modpost.c |    4 +++-
> >  2 files changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> > index ad2434b..64ad9cf 100644
> > --- a/scripts/kallsyms.c
> > +++ b/scripts/kallsyms.c
> > @@ -105,8 +105,9 @@ static int read_symbol(FILE *in, struct sym_entry *s)
> >  	else if (toupper(stype) == 'U' ||
> >  		 is_arm_mapping_symbol(sym))
> >  		return -1;
> > -	/* exclude also MIPS ELF local symbols ($L123 instead of .L123) */
> > -	else if (str[0] == '$')
> > +	/* exclude also MIPS ELF (e.g. $L123) and h8300 elf (e.g. .LM123)
> > +	   local symbols */
> > + 	else if (str[0] == '$' || str[0] == '.')
> >  		return -1;
> >  	/* exclude debugging symbols */
> >  	else if (stype == 'N')
> > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> > index 418cd7d..e07f4ba 100644
> > --- a/scripts/mod/modpost.c
> > +++ b/scripts/mod/modpost.c
> > @@ -1042,7 +1042,9 @@ static inline int is_valid_name(struct elf_info *elf, Elf_Sym *sym)
> >  {
> >  	const char *name = elf->strtab + sym->st_name;
> >  
> > -	if (!name || !strlen(name))
> > +	if (!name || !strlen(name) ||
> > +	/* exclude h8300 elf local symbols (e.g. .LM123) */
> > +	    name[0] == '.')
> >  		return 0;
> >  	return !is_arm_mapping_symbol(name);
> >  }
> 
> This patch broke kallsyms on powerpc.  Please see
> http://ozlabs.org/pipermail/linuxppc-dev/2008-September/062549.html

Hmm...
h8300 local symbol head of '.L'.
But powerpc don't have '.L' pattern.
I think add condition "str[1] == 'L'".

-- 
Yoshinori Sato
<ysato@xxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/