Re: [PATCH 0/3] smp: reduce stack requirements forsmp_call_function_mask

From: David Miller
Date: Mon Sep 08 2008 - 15:52:16 EST


From: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
Date: Mon, 8 Sep 2008 20:30:41 +1000

> Is that being tried? Setting it to 8192 or even higher during QA seems
> like a good idea to me.

This is a great idea, especially since it will make it even more
painfully obvious that essentially any function local cpumask_t
variable is a bug.

Really, it seems sensible to do something like:

1) Make cpumask_t a pointer.

2) Add cpumask_data_t which is what cpumask_t is now. This gets
used when for the actual storage, and will only get applied to
datastructures that are dynamically allocated. For example, for
the cpu_vm_mask in mm_struct.

3) Type make and fix build failures until they are all gone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/