Re: [PATCH] [1/2] Add a SYSTEM_PANIC state

[Andrew Morton]

On Wed, 3 Sep 2008 21:16:51 +0200
Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> On Wed, Sep 03, 2008 at 12:04:23PM -0700, Andrew Morton wrote:
> > On Tue,  2 Sep 2008 15:49:22 +0200 (CEST)
> > Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > 
> > > --- linux.orig/include/linux/kernel.h
> > > +++ linux/include/linux/kernel.h
> > > @@ -248,6 +248,7 @@ extern enum system_states {
> > >  	SYSTEM_POWER_OFF,
> > >  	SYSTEM_RESTART,
> > >  	SYSTEM_SUSPEND_DISK,
> > > +	SYSTEM_PANIC,
> > >  } system_state;
> > 
> > system_state is such a crock.  I wonder what other random code all over
> > the place is looking at system_state and will get unexpectedly broken
> > by other "unrelated" changes such as this..
> 
> >From a quick grep none.
> 
> Also I think it's a natural extension.
> 
> > 
> > 
> > It's not a heck of a lot nicer, but we could do this:
> 
> Sorry but I think it's far worse. How do you think it's
> better?
> 

For the reason which I stated and which you carefully deleted prior to
asking my reason.

Sheesh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/