Re: [PATCH 1/2] utrace core

From: Alexey Dobriyan
Date: Sat Aug 30 2008 - 11:04:30 EST


On Tue, Aug 26, 2008 at 03:01:57PM -0700, Roland McGrath wrote:
> +/**
> + * struct utrace_attached_engine - per-engine structure
> + * @ops: &struct utrace_engine_ops pointer passed to utrace_attach_task()
> + * @data: engine-private &void * passed to utrace_attach_task()
> + * @flags: event mask set by utrace_set_events() plus internal flag bits
> + *
> + * The task itself never has to worry about engines detaching while
> + * it's doing event callbacks. These structures are removed from the
> + * task's active list only when it's stopped, or by the task itself.
> + *
> + * utrace_engine_get() and utrace_engine_put() maintain a reference count.
> + * When it drops to zero, the structure is freed. One reference is held
> + * implicitly while the engine is attached to its task.
> + */
> +struct utrace_attached_engine {
> +/* private: */
> + struct kref kref;

Engine grew a refcount.

Was it added to fix some bug?

Old utrace git doesn't have this, new utrace git has only two
posted patches, so asking.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/