Re: [PATCH RFC] x86: check for and defend against BIOS memory corruption

From: RafaÅ MiÅecki
Date: Fri Aug 29 2008 - 13:40:15 EST


2008/8/29 Hugh Dickins <hugh@xxxxxxxxxxx>:
> Here's my version of Jeremy's patch, that I've now tested on my machines,
> as x86_32 and as x86_64. It addresses none of the points Alan Cox made,
> and it stays silent for me, even after suspend+resume, unless I actually
> introduce corruption myself. Omits Jeremy's check in fault.c, but does
> a check every minute, so should soon detect RafaÅ's HDMI corruption
> without any need to suspend+resume.

Your periodic test works fine:

Corrupted low memory at ffff88000000be9c (be9c phys) = b02a0004
<IRQ> [<ffffffff8020fc9b>] check_for_bios_corruption+0x93/0x9f
[<ffffffff8020fca7>] ? periodic_check_for_corruption+0x0/0x25
[<ffffffff8020fcb0>] periodic_check_for_corruption+0x9/0x25

By the way I confirmed this bug on Sony Vaio FW11M (my one is FW11S).
Probably more machines from FW11* are affected.

--
RafaÅ MiÅecki
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_