Re: [PATCH] seqlock: serialize against writers

From: Andi Kleen
Date: Fri Aug 29 2008 - 12:09:30 EST


Gregory Haskins <ghaskins@xxxxxxxxxx> writes:

> *Patch submitted for inclusion in PREEMPT_RT 26-rt4. Applies to 2.6.26.3-rt3*
>
> Hi Ingo, Steven, Thomas,
> Please consider for -rt4. This fixes a nasty deadlock on my systems under
> heavy load.

Does this even work under x86-64? x86-64 uses seqlocks in user space
in its vsyscalls. And read_lock() definitely doesn't work there because
it writes.

You would need at least to disable vsyscall gettimeofday(), making
it much much slower.

Perhaps you tested on one of the systems where the vsyscalls need
to fallback for other reasons? (e.g. one using pmtimer for timing).

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/