Re: Regression: SATA disk double spin-off during hibernation on hp nx6325

[Rafael J. Wysocki]

On Friday, 29 of August 2008, Tejun Heo wrote:
> Hello,
> 
> Rafael J. Wysocki wrote:
> > It appears that the "double spin-off" problem described in
> > 
> > http://bugzilla.kernel.org/show_bug.cgi?id=8855
> > 
> > has recently started to appear during hibernation as well as during shutdown.
> > It didn't appear during hibernation on my hp nx6325 with 2.6.26, so this is a
> > recent regression.
> > 
> > I have prepared the appended patch that fixes the problem for me, based on the
> >  earlier Tejun's patch at
> > 
> > http://bugzilla.kernel.org/attachment.cgi?id=15441&action=view
> > 
> > but I'm not really sure if this is an acceptable solution.  Please advise.
> > 
> > Thanks,
> > Rafael
> > 
> > 
> > not-yet-signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> The libata part looks fine to me but what are those SYSTEM_SUSPEND_DISK
> stuff?  They don't look like belonging to this patch.

Actaully, they do belong to it.  This is the part "fixing" the hibernation code
path, in which the disk is also powered off unnecessarily.

Well, probably I should use SYSTEM_HIBERNATE_ENTER or something similar
instead of SYSTEM_SUSPEND_DISK.

In short, the idea is to change system_state to something specific to the last
phase of hibernation (after saving the image) and check that in
ata_scsi_start_stop_xlat().  In fact that's completely analogous to what's done
for SYSTEM_POWER_OFF in there.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/