Re: [Patch] Check hfs_bnode_find return value

[Roman Zippel]

Hi,

On Tue, 26 Aug 2008, Eric Sesterhenn wrote:

> --- linux/fs/hfsplus/brec.c.orig	2008-08-26 19:18:56.000000000 +0200
> +++ linux/fs/hfsplus/brec.c	2008-08-26 19:19:27.000000000 +0200
> @@ -304,6 +304,8 @@ static struct hfs_bnode *hfs_bnode_split
>  	/* update next bnode header */
>  	if (new_node->next) {
>  		struct hfs_bnode *next_node = hfs_bnode_find(tree, new_node->next);
> +		if (IS_ERR(next_node))
> +			return next_node;
>  		next_node->prev = new_node->this;
>  		hfs_bnode_read(next_node, &node_desc, 0, sizeof(node_desc));
>  		node_desc.prev = cpu_to_be32(next_node->prev);

Al Viro already fixed this for HFS in a better way, could you please adopt 
his solution?

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/