Re: 2.6.27-rc4: lots of 'in_atomic():1, irqs_disabled():0' with software-raid1

From: Jens Axboe
Date: Thu Aug 28 2008 - 04:12:23 EST


On Thu, Aug 28 2008, Andre Noll wrote:
> On 09:48, Jens Axboe wrote:
> > Doh right, we of course can't block inside a RCU section. Then
> > bitmap.c:write_sb_page() wants fixing:
> >
> > rcu_read_lock();
> > rdev_for_each_rcu(...)
> > md_super_write(...)
> > bio_alloc(GFP_NOIO, 1);
>
> Also, md_super_write() does not check the return value of bio_alloc().
> That probably needs fixing as well.

No, that's the guarentee of mempool_alloc() - as long as you have
__GFP_WAIT set, you'll never see a NULL return.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/