Re: [PATCH] devcgroup: remove unused variable

From: Serge E. Hallyn
Date: Mon Aug 25 2008 - 12:44:15 EST


Quoting Li Zefan (lizf@xxxxxxxxxxxxxx):
>
> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

Yup.

Acked-by: Serge Hallyn <serue@xxxxxxxxxx>

thanks,
-serge

> ---
> security/device_cgroup.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 9c625f6..d5c15a7 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -355,7 +355,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> struct dev_cgroup *cur_devcgroup;
> const char *b;
> char *endp;
> - int retval = 0, count;
> + int count;
> struct dev_whitelist_item wh;
>
> if (!capable(CAP_SYS_ADMIN))
> @@ -432,7 +432,6 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
> }
>
> handle:
> - retval = 0;
> switch (filetype) {
> case DEVCG_ALLOW:
> if (!parent_has_perm(devcgroup, &wh))
> --
> 1.5.4.rc3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/