RE: [PATCH] pci: change msi-x vector to 32bit
From: H. Peter Anvin
Date: Fri Aug 15 2008 - 23:27:45 EST
The 28 bits aren't enough, are they: we need domain as well (and surely we can have more than 16 domains?)
-hpa
--
Sent from my mobile phone (pardon any lack of formatting)
-----Original Message-----
From: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
Sent: Friday, August 15, 2008 19:36
To: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>; James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; Ingo Molnar <mingo@xxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; H. Peter Anvin <hpa@xxxxxxxxx>; Eric W. Biederman <ebiederm@xxxxxxxxxxxx>; Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx; Yinghai Lu <yhlu.kernel@xxxxxxxxx>; Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
Subject: [PATCH] pci: change msi-x vector to 32bit
we are using 28bit pci (bus/dev/fn + 12 bits) as irq number, so the
cache for irq number should be 32 bit too.
Signed-off-by: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
Cc: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
---
drivers/scsi/qla2xxx/qla_def.h | 2 +-
include/linux/pci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/qla2xxx/qla_def.h
===================================================================
--- linux-2.6.orig/drivers/scsi/qla2xxx/qla_def.h
+++ linux-2.6/drivers/scsi/qla2xxx/qla_def.h
@@ -2109,7 +2109,7 @@ struct scsi_qla_host;
struct qla_msix_entry {
int have_irq;
- uint16_t msix_vector;
+ uint32_t msix_vector;
uint16_t msix_entry;
};
Index: linux-2.6/include/linux/pci.h
===================================================================
--- linux-2.6.orig/include/linux/pci.h
+++ linux-2.6/include/linux/pci.h
@@ -730,7 +730,7 @@ enum pci_dma_burst_strategy {
};
struct msix_entry {
- u16 vector; /* kernel uses to write allocated vector */
+ u32 vector; /* kernel uses to write allocated vector */
u16 entry; /* driver uses to specify entry, OS writes */
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/