Re: [PATCH]: PCI: GART iommu alignment fixes [v2]

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> 
> * FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> wrote:
> 
> > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> > Subject: [PATCH] x86 gart: allocate size-aligned address for alloc_coherent
> > 
> > This fixes GART to return a properly aligned address as
> > DMA-mapping.txt defines.
> 
> applied to tip/x86/gart, thanks! Any v2.6.27-urgency of this patch?

hm, -tip testing has found that this patch causes a hard hang during 
bootup:

 initcall ali_init+0x0/0x1b returned 0 after 3 msecs
 calling  amd_init+0x0/0x1b
 bus: 'pci': add driver pata_amd
 bus: 'pci': driver_probe_device: matched device 0000:00:06.0 with driver pata_amd
 bus: 'pci': really_probe: probing driver pata_amd with device 0000:00:06.0
 pata_amd 0000:00:06.0: version 0.3.10
 pata_amd 0000:00:06.0: setting latency timer to 64
 [hard hang]

should have continued with:

 scsi0 : pata_amd
 device: 'host0': device_add
 device: 'host0': device_add
 scsi1 : pata_amd
 [... etc. ... ]

on an AMD X2 testsystem. (Asus board) Can send more info on request. 
Config is:

  http://redhat.com/~mingo/misc/config-Fri_Aug_15_18_30_56_CEST_2008.bad

Any idea why that is so? Apparently the alignment change wasnt as benign 
as assumed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/