Re: [patch 1/3] kmsg: Kernel message catalog macros.

From: Greg KH
Date: Fri Aug 15 2008 - 12:06:59 EST


On Thu, Aug 14, 2008 at 10:33:10PM -0700, Tim Hockin wrote:
> On Thu, Aug 14, 2008 at 8:44 PM, Greg KH <gregkh@xxxxxxx> wrote:
> >
> > What is wrong with what we have already agreed to standardise on here
> > people? dev_printk() for devices! It uniquely shows the device, what
> > driver is bound to it (if any), the bus id, and everything else.
>
> Part of the problem, imho, is the "if any" part. But I am more than happy to
> build on existing solutions. All the world is not a dev, though.

No, but way over half the kernel is.

> I'd like to be able to report something like an OOM kill in (roughly)
> the same way as an ATA error, and I want (though could be talked out
> of) a way to tell these "events" (for lack of a better word) apart
> from plain-old-printk()s.

That's great, then create something that can handle both! Don't throw
away some wonderful information that way over half the kernel has access
to just because the minority doesn't. That would mean that we would
loose information in those drivers overall.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/