Re: [patch 2/2] reduce tlb/cache flush times of agpgart memoryallocation

From: Arjan van de Ven
Date: Fri Aug 15 2008 - 10:40:51 EST


On Fri, 15 Aug 2008 16:31:31 +0200
Ingo Molnar <mingo@xxxxxxx> wrote:

>
> * Shaohua Li <shaohua.li@xxxxxxxxx> wrote:
>
> > To reduce tlb/cache flush, makes agp memory allocation do one flush
> > after all pages in a region are changed to uc.
> >
> > All agp drivers except agp-sgi uses agp_generic_alloc_page() for
> > .agp_alloc_page, so the patch should work for them. agp-sgi is only
> > for ia64, so not a problem too.
>
> applied to tip/x86/pat - thanks!
>
> I've Cc:-ed more PAT folks - any objections?
>

it really needs something else instead; it needs airlied's array
allocator
otherwise you hit the second wall as well (the pat checks per page)

in reality an array version of ioremap (or set_pages_X) is what is
needed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/