Re: [PATCH](retry 4) invalidate caches before going into suspend

From: Ingo Molnar
Date: Fri Aug 15 2008 - 08:05:02 EST



* Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:

> When a CPU core is shut down, all of its caches need to be flushed to
> prevent stale data from causing errors if the core is resumed. Current
> Linux suspend code performs an assignment after the flush, which can
> add dirty data back to the cache.  On some AMD platforms, additional
> speculative reads have caused crashes on resume because of this dirty
> data.
>
> Relocate the cache flush to be the very last thing done before
> halting.  Tie into an assembly line so the compile will not reorder
> it.  Add some documentation explaining what is going on and why we're
> doing this.
>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@xxxxxxx>
> Acked-by: Mark Borden <mark.borden@xxxxxxx>
> Acked-by: Michael Hohmuth <michael.hohmuth@xxxxxxx>

applied to tip/x86/urgent - thanks Mark.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/