Re: [PATCH](retry 2) Re: invalidate caches before going intosuspend

[Arjan van de Ven]

On Wed, 13 Aug 2008 13:33:17 -0500
Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:
> +	/* mask all interrupts, flush any and all caches, and halt */
> +	if (cpu_has_clflush)
> +		wbinvd_halt();
> +	else
> +		while (1)
> +			halt();
>  }

I like the asm version .. but this code makes me blink.
when you HAVE clflush you do wbinvd.
yeah I know it's correct but... it reads wonky ;)
also.. can we move that check into the wbinvd_halt() itself, so that
the callers don't need to care what is used to select it ?

-- 
If you want to reach me at my work email, use arjan@xxxxxxxxxxxxxxx
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/