Re: [PATCH] ISDN: make ICN not auto-grab port 0x320

From: Rene Herman
Date: Tue Aug 12 2008 - 01:02:29 EST


On 12-08-08 01:48, Andrew Morton wrote:

otoh it's a bit sad to break allyesconfig kernels - there is
regression-testing value in being able to run such kernels.

I wonder if we can add a new boot option `allyesconfig-test' or
something like that, and then, within the offending drivers, test that
flag and take suitable avoiding action.

Or we could do it at compile-time - define
CONFIG_ALLYESCONFIG_TESTING in some fashion.

Yes, latter I'd feel with the thing most against it that there aren't actually many that need it. Here's the list that was posted:

http://lkml.org/lkml/2008/8/1/96

Three legacy ISA driver from that list can now be stricken. Hurrah.

There's always going to be at least a few that'll remain though. For example, what are you going to do with:

--- linux.orig/drivers/ide/Kconfig
+++ linux/drivers/ide/Kconfig
@@ -9,6 +9,11 @@ config HAVE_IDE
menuconfig IDE
tristate "ATA/ATAPI/MFM/RLL support"
depends on HAVE_IDE
+
+ # my test box expects /dev/sda, not /dev/hda
+ depends on BROKEN_BOOT_ALLOWED
+ select BROKEN_BOOT if IDE = y
+
depends on BLOCK
---help---
If you say Y here, your kernel will be able to manage low cost

The hda->sda thing was just a disaster -- personally I have to remember to change things around till this very day before I boot into my distro kernel to test things. I wouldn't be the one suggesting a patch to drivers/ide to "fix" that though including really a patch to its Kconfig marking it as breaking anything in a global way rather than a user-specific way as was done here.

Maybe the test boxes should always boot with ide_core.noprobe=<all> for a suitable value of <all> or some such...

Others are the video ones. FB_VESA, FB_VGA16FB and even MDA_CONSOLE are in there which seems to imply some decidly non-legacy hardware and I sort of doubt willingness to assume global validity of such a setup.

But yes, there is value in the testing so perhaps still worh something generic.

(I'll continue some specific looking through the list first although I don't believe there is much else that really wants specific fixing).

Rene.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/