Re: OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output,rt6_fill_node+0x175

From: Brian Haley
Date: Mon Aug 11 2008 - 20:41:40 EST


Eugene Teo wrote:
I think it's better to use a helper routine like ipv6_get_saddr to make
sure that both dst and rt6i_idev arguments are checked for NULL.

I have compiled, and tested the patch.

Thanks,
Eugene

---
Fix NULL pointer dereference in rt6_fill_node().

# ip -f inet6 route get fec0::1

BUG: unable to handle kernel NULL pointer dereference at 00000000
IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0
EIP is at rt6_fill_node+0x175/0x3b0

Cc: Stable <stable@xxxxxxxxxx>
Signed-off-by: Eugene Teo <eugeneteo@xxxxxxxxx>

Acked-by: Brian Haley <brian.haley@xxxxxx>

But Yoshfuji might have another opinion since he did the work to remove ipv6_get_saddr() in the first place.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/