Re: [PATCH -tip] x86: apic interrupts - move assignments toirqinit_32.c

From: Ingo Molnar
Date: Mon Aug 11 2008 - 09:07:23 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
>
> > 64bit mode APIC interrupt handlers are set within irqinit_64.c.
> > Lets do tha same for 32bit mode which would help in furter code merging.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx>
> > ---
> >
> > I found it useful for APIC code merging process (in which
> > i'm now). So please review and test if possible.
> > Any comments are quite welcome!
> >
> > Ugh... almost forget - the patch is over -tip tree
> > commit 62c67a7cc7dbd9c8d92d49cfd7d5ca1d8f354616
>
> applied to tip/x86/core for more testing, thanks Cyrill.

doesnt build:

arch/x86/mach-default/setup.c:44: warning: âirq2â defined but not used
arch/x86/kernel/irqinit_32.c: In function ânative_init_IRQâ:
arch/x86/kernel/irqinit_32.c:139: error: âirq2â undeclared (first use in this function)
arch/x86/kernel/irqinit_32.c:139: error: (Each undeclared identifier is reported only once
arch/x86/kernel/irqinit_32.c:139: error: for each function it appears in.)

with:

http://redhat.com/~mingo/misc/config-Mon_Aug_11_14_48_29_CEST_2008.bad

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/