Re: [RFC PATCH] cleanup Serial ATA and Parallel ATA Kconfig

[Krzysztof Halasa]

Grant Coady <grant_lkml@xxxxxxxxxxx> writes:

>   Â Â    --- Serial ATA (SATA) and Parallel ATA (PATA) drivers            Â Â
>   Â Â    <*>   AHCI SATA support                                          Â Â
>   Â Â    [*]   ATA ACPI Support                                           Â Â
>   Â Â    [ ]   SATA Port Multiplier support                               Â Â
>   Â Â    < >   Silicon Image 3124/3132 SATA support                       Â Â
>   Â Â    [*]   ATA SFF support                                            Â Â
>   Â Â            *** Serial ATA drivers ***                               Â Â
>   Â Â    < >     Initio 162x SATA support                                 Â Â
>   Â Â    < >     Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support           Â Â

As noted, it's both PATA and SATA. People searching for PATA-only PIIX
support may have trouble locating it under SATA.

Why not remove ATA SFF support visual option (or leave it for optional
off-tree drivers only, if it makes sense) and SELECT it when any
driver using it is selected? I'm not sure that users know they need
SFF, or what's that.

I think I would also ask for PATA and for SATA first:

[*] PATA support
[*] SATA support
... PATA drivers if "PATA support" is selected
... SATA drivers if "SATA support" is selected
... PIIX is PATA and/or SATA support is selected

I guess all PATA and/or SATA drivers in a single sorted list (so PIIX
doesn't break ordering).
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/