Re: [PATCH 00/42] dyn_array/nr_irqs/sparse_irq support v5

From: Yinghai Lu
Date: Fri Aug 08 2008 - 18:26:42 EST


On Fri, Aug 8, 2008 at 3:19 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Yinghai Lu wrote:
>>
>> based on tip/master
>>
>> to do:
>> so dyn irq_desc is done, and ready to:
>> make create_irq to get irq according to bus/dev/func/vector
>>
>
> Hm... I tried to check this in as a separate topic branch, but it conflicts
> against both linus and against tip:x86/core, which are the branches we
> usually base topic branches on.

Ingo said, I only need to work on tip/master, and you guys will sort it out.
Eric's NR_IRQS patch for 2.6.27 is not in tip yet. --- Andrew picked up already

maybe i need put eric's patch before alan's patch in next sending...

>
> I really am not convinced about the whole dyn_array concept, and
> *especially* not having divergences between 32 and 64 bits with regards to
> sparse IRQs. Furthermore, there are a number of checkpatch errors for this
> patch series, most of which appear legit.

will check it. it could be just replace irq_desc[] to irq_desc()...

>
> So again... any reason to not just have sparse IRQs and be done with it?

another reason: dyn_arry == static in some case, so I could make sure
compiling work well between static/dyn_array with sparse_irq.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/