Re: [patch 3/5] [PATCH 3/5] x86: Run Intel ucode-updates via workqueue.

From: Max Krasnyansky
Date: Wed Aug 06 2008 - 16:34:33 EST


Arjan van de Ven wrote:
On Wed, 6 Aug 2008 17:21:20 +0200
Peter Oruba <peter.oruba@xxxxxxx> wrote:

[ no description or reason ]

Why is this?

I'm not very happy about this.. it means practically that this stuff
*has* to run late. Probably later than we want to.
(Like.. we may want to redo the microcode during resume.. which is
not a schedulable context)

Dmitry and I tried to figure out how soon does it need to run.
Nobody had a strong argument why it must run synchronously in the hotplug path. Sure we want it as soon as possible and I'd say workqueue is soon enough.
Existing hotplug path does not guaranty any ordering and original microcode interface was driven from user-space. So clearly it was not considered very critical.

Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/