Re: [PATCH] cifs: avoid mixing bool and le16

From: Harvey Harrison
Date: Wed Jul 23 2008 - 20:24:21 EST

On Wed, 2008-07-23 at 19:19 -0500, Steve French wrote:
> Seems like a cast to bool or an "if ...else" would be clearer than using !!
> By the way I don't see this warning - is it a newer compiler warning?

Sorry, sometimes I forget to say sparse warning. This is with
__CHECK_ENDIAN__ as well.

Would you prefer:
if (pSMBr->hdr.Flags2 & SMBFLG2_UNICODE)
is_unicode = true;
is_unicode = false;



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at